fix(coverage): bump coverage.py to 7.10.7 for Python 3.14 support#3592
fix(coverage): bump coverage.py to 7.10.7 for Python 3.14 support#3592slaptijack wants to merge 2 commits intobazel-contrib:mainfrom
Conversation
Summary of ChangesHello @slaptijack, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses the need for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates coverage.py to version 7.10.7 to add support for Python 3.14. The changes include updating dependency definitions, modifying the patch file for better compatibility, and updating the dependency generation script. My review found an issue in the update script where it retains support for Python 3.8, which is no longer supported by the new coverage.py version, causing the script to fail. A fix has been suggested.
6d83163 to
db042d8
Compare
Why
rules_pythoncoverage support needs to work on Python 3.14, but we also needto keep Python 3.9 compatibility for users not yet on newer runtimes.
What changed
coverage.pywheel set to7.10.7inpython/private/coverage_deps.bzl.tools/private/update_deps/update_coverage_deps.pyso regeneratedcoverage deps correctly include:
cp314by defaultpython/private/coverage.patch,but narrowed patch context so it applies reliably across newer coverage wheel layouts.
CHANGELOG.md.Before
versions dropped Python 3.9 support.
After
7.10.7, which supports both Python 3.9 and Python 3.14.Testing
bazel test //tests/python:python_tests //tests/py_runtime:py_runtime_tests --test_tag_filters=-integration-testbazel coverageend-to-end in a minimal repro workspaceusing this branch via
local_path_override.